Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Visual] [Material] Can't set TextColor and BackgroundColor for a disabled Material button #9261

Closed
quentinR0bert opened this issue Jan 20, 2020 · 4 comments · Fixed by #9655
Closed

[Visual] [Material] Can't set TextColor and BackgroundColor for a disabled Material button #9261

quentinR0bert opened this issue Jan 20, 2020 · 4 comments · Fixed by #9655
Labels
a/visual a/VSM in-progress This issue has an associated pull request that may resolve it! t/bug 🐛

Comments

@quentinR0bert
Copy link

quentinR0bert commented Jan 20, 2020 •
edited
Loading

Description

The color declarated in TextColor and BackgroundColor with a VisualStateManager doesn't is the colors seen

Steps to Reproduce

  1. Declare a Style for Buttons with a VisualStateManager and set some other colors for the background or the textColor
  2. Set dynamically the button disabled
  3. The Color show is not the one declarated

Expected Behavior

Actual Behavior

Basic Information

  • Version with issue:4.4.0.991477
@quentinR0bert quentinR0bert added s/unverified New report that has yet to be verified t/bug 🐛 labels Jan 20, 2020
@samhouts
Copy link
Member

@quentinR0bert Can you please attach a small project that demonstrates this issue? Thanks!

@samhouts samhouts added s/needs-info ❓ A question has been asked that requires an answer before work can continue on this issue. s/needs-repro ❔ This reported issue doesn't include a sample project reproducing the issue. Please provide one. labels Jan 23, 2020
@quentinR0bert
Copy link
Author

Hi,
There is a sample with a default style setting the Background to Blue and the TextColor to White, with a VisualStateManager normally setting the background to Red and the TextColor to White.

You will see that then we set the button disabled the background become kind of pink and the TextColor become Red.
Forms44.zip

@samhouts samhouts removed s/needs-info ❓ A question has been asked that requires an answer before work can continue on this issue. s/needs-repro ❔ This reported issue doesn't include a sample project reproducing the issue. Please provide one. labels Jan 28, 2020
@PureWeen PureWeen mentioned this issue Feb 20, 2020
Merged
2 tasks
@PureWeen PureWeen removed the s/unverified New report that has yet to be verified label Feb 20, 2020
@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label Feb 20, 2020
@samhouts
Copy link
Member

closed by #9655

@quentinR0bert
Copy link
Author

Hi !

Thanks for the fix, but the #9655 only fix for the TextColor and not the BackgroundColor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
a/visual a/VSM in-progress This issue has an associated pull request that may resolve it! t/bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set text color for disabled states on material buttons xamarin/Xamarin.Forms
3 participants
@PureWeen @samhouts @quentinR0bert