Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

CollectionView LinearItemsLayout strange behavior on Android[Bug] [CollectionView] [Android] #9681

Closed
dimonovdd opened this issue Feb 22, 2020 · 3 comments · Fixed by #10624
Closed

CollectionView LinearItemsLayout strange behavior on Android[Bug] [CollectionView] [Android] #9681

dimonovdd opened this issue Feb 22, 2020 · 3 comments · Fixed by #10624
Labels
a/collectionview a/layout in-progress This issue has an associated pull request that may resolve it! p/Android t/bug 🐛 up-for-grabs We welcome community contributions to any issue, but these might be a good place to start!
Projects
CollectionView

Comments

@dimonovdd
Copy link
Contributor

Description

The CollectionView has an unpleasant bug on Android. On UWP and iOS it hasn't been noticed.

When selecting LinearItemsLayout and setting ItemSpacing, the ItemSpacing on Android does not always work

I have created a project to repeat this bug

Steps to Reproduce

  1. Run my test project
  2. Open The "Android Bug Page"
  3. Click the "add Item" button several times
  4. Click the "delete first item" button"

Reproduction Link

https://github.com/dimonovdd/CollectionViewBug.git
@dimonovdd dimonovdd added s/unverified New report that has yet to be verified t/bug 🐛 labels Feb 22, 2020
@pauldipietro pauldipietro added this to New in Triage Feb 22, 2020
@jsuarezruiz jsuarezruiz added a/collectionview p/Android a/layout and removed s/unverified New report that has yet to be verified labels Feb 25, 2020
@jsuarezruiz jsuarezruiz moved this from New to Needs Estimate in Triage Feb 25, 2020
@jsuarezruiz
Copy link
Contributor

Thanks for the repro sample. I reproduce the issue, the problem is that the ItemSpacing does not apply well until scrolling.

issue9681

I have done other tests applying margins, etc. to each item and the same thing happens. The layout is fixed when scrolling, etc.

Seems to be the same issue as #9645

@dimonovdd
Copy link
Contributor Author

Thanks for the repro sample. I reproduce the issue, the problem is that the ItemSpacing does not apply well until scrolling.

issue9681

I have done other tests applying margins, etc. to each item and the same thing happens. The layout is fixed when scrolling, etc.

Seems to be the same issue as #9645

As I understood, it is not only connected with scrolling. The ItemSpacing also gets updated when I add several items and then remove the first item (with no scrolling at all).

@samhouts samhouts added this to Backlog in CollectionView Mar 10, 2020
@samhouts samhouts added this to the 5.0.0 milestone Aug 13, 2020
@samhouts samhouts added this to To do in vNext+1 (5.0.0) Aug 14, 2020
@samhouts samhouts added inactive Issue is older than 6 months and needs to be retested help wanted We welcome community contributions to any issue, but these might be a good place to start! up-for-grabs We welcome community contributions to any issue, but these might be a good place to start! and removed inactive Issue is older than 6 months and needs to be retested help wanted We welcome community contributions to any issue, but these might be a good place to start! labels Sep 18, 2020
@samhouts samhouts removed this from the 5.0.0 milestone Nov 2, 2020
@dimonovdd
Copy link
Contributor Author

dimonovdd commented Nov 26, 2020 •
edited
Loading

@samhouts why was this removed from the milestone 5.0.0? this is a very important issue.

@hartez hartez mentioned this issue Dec 16, 2020
Merged
2 tasks
@hartez hartez added the in-progress This issue has an associated pull request that may resolve it! label Dec 16, 2020
@hartez hartez removed this from Needs Estimate in Triage Dec 16, 2020
@hartez hartez moved this from Backlog to In Review in CollectionView Dec 16, 2020
CollectionView automation moved this from In Review to Done Dec 18, 2020
rmarinho added a commit that referenced this issue Dec 18, 2020
@ChummerUA @hartez @rmarinho
[Android] Fix incorrect spacing in CollectionView with multiple spans (…
208f8ea 
…#10624) fixes #9125 fixes #10585 fixes #13054 fixes #9681

* -fixed incorrect outRect values

* fixed unassigned offsets

* -fixed incorrect lastSpanIndex and outRect values

* -fixed itemdecorations stayed same when collection is updated

* Fix indexes in notifications

* Fix hang when inserting item in CarouselView

* Fix timing issue with Carousel current item when inserting

* Use GetSpanGroupIndex to determine first row/column

* Fix starting index for looped CarouselView

* Fix Carousel tests so they don't all fail when one fails;
Fix Carousel tests so they don't take 30 minutes to run;

* Fix index offset on looped Carousel;

Co-authored-by: E.Z. Hart <hartez@gmail.com>
Co-authored-by: Rui Marinho <me@ruimarinho.net>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
a/collectionview a/layout in-progress This issue has an associated pull request that may resolve it! p/Android t/bug 🐛 up-for-grabs We welcome community contributions to any issue, but these might be a good place to start!
Projects
CollectionView
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Android] Fix incorrect spacing in CollectionView with multiple spans
4 participants
@hartez @jsuarezruiz @samhouts @dimonovdd