Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Xamarin.Forms 4.5 breaks custom frame renderer shadow functionality on iOS #9774

Closed
doriangh opened this issue Feb 28, 2020 · 9 comments
Labels
a/frame e/5 🕔 5 in-progress This issue has an associated pull request that may resolve it! p/iOS 🍎 t/bug 🐛

Comments

@doriangh
Copy link

Description

When making a custom frame renderer for iOS and changing the shadow properties, they do not get applied on Xamarin 4.5. Moreover, the custom renderer does not extend, but rather overwrite the Xamarin Forms implementation.

Steps to Reproduce

  1. Make a new Xamarin Forms project
  2. Create a custom frame renderer
  3. Modify the shadow of the custom frame renderer

Expected Behavior

The custom frame renderer extends the properties of the current frame, modifying only the shadow.

Actual Behavior

The custom frame renderer does not affect the shadow, sets the default shadow.

Basic Information

  • Version with issue: 4.5.0.356
  • Last known good version: 4.4.0.991757
  • IDE: Visual Studio for Mac
  • Nuget Packages: Xamarin.Forms, Xamarin.Essentials
  • Affected Devices: iOS

Screenshots

How it should look:
Screenshot 2020-02-28 at 16 24 45

How it looks in Xamarin.Forms 4.5
Screenshot 2020-02-28 at 16 37 52

Reproduction Link

https://github.com/doriangh/Xamarin-Forms-4.5-issue

@doriangh doriangh changed the title Xamarin 4.5 breaks custom frame renderer shadow functionality on iOS Xamarin.Forms 4.5 breaks custom frame renderer shadow functionality on iOS Feb 28, 2020
@pauldipietro pauldipietro added this to New in Triage Feb 28, 2020
@doriangh doriangh changed the title Xamarin.Forms 4.5 breaks custom frame renderer shadow functionality on iOS [Bug] Xamarin.Forms 4.5 breaks custom frame renderer shadow functionality on iOS Feb 28, 2020
@jsuarezruiz jsuarezruiz added p/iOS 🍎 s/unverified New report that has yet to be verified t/bug 🐛 labels Mar 2, 2020
@hartez
Copy link
Contributor

hartez commented Mar 3, 2020

Duplicate of #9265

@hartez hartez marked this as a duplicate of #9265 Mar 3, 2020
@hartez hartez added this to To do in iOS Ready For Work via automation Mar 3, 2020
@hartez hartez added e/5 🕔 5 a/frame and removed s/unverified New report that has yet to be verified labels Mar 3, 2020
@hartez hartez removed this from New in Triage Mar 3, 2020
@ashleypringle
Copy link

We're also experiencing this problem. Reverting to Forms version 4.4.0.991265 fixed the issue.

rmarinho pushed a commit that referenced this issue Mar 20, 2020
…9265, #9774

Co-authored-by: Yuriy Holembyovskyy <yuriy.holembyovskyy@gmail.com>
@samhouts samhouts added this to In Progress in v4.5.0 Mar 27, 2020
@samhouts samhouts moved this from In Progress to Done in v4.5.0 Mar 27, 2020
@samhouts
Copy link
Member

closed by #10023

iOS Ready For Work automation moved this from To do to Done Mar 31, 2020
@doriangh
Copy link
Author

doriangh commented Apr 19, 2020

@samhouts I still can't get this to work with the exact setup in the latest XF 4.5 sr4 (4.5.0.617).

@liveinvarun
Copy link

@samhouts This issue is still happening in 4.5.0.617 and pre versions too. Can you confirm which version has the fix and also reopen the ticket.

@samhouts samhouts reopened this May 1, 2020
iOS Ready For Work automation moved this from Done to In progress May 1, 2020
v4.5.0 automation moved this from Done to To do May 1, 2020
@jfversluis jfversluis mentioned this issue May 2, 2020
2 tasks
@cheles
Copy link

cheles commented May 4, 2020

it's still present in XF 4.6.0.726

@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label May 5, 2020
@samhouts samhouts removed this from Done in v4.6.0 Jul 29, 2020
@samhouts samhouts added this to In Progress in v4.6.0 Jul 29, 2020
@samhouts samhouts moved this from In Progress to Done in v4.6.0 Jul 29, 2020
@samhouts samhouts removed this from Done in v4.6.0 Jul 29, 2020
@samhouts samhouts added this to In Progress in v4.6.0 Jul 29, 2020
@samhouts samhouts moved this from In Progress to Done in v4.6.0 Jul 29, 2020
@samhouts samhouts removed this from Done in v4.6.0 Jul 29, 2020
@samhouts samhouts added this to In Progress in v4.6.0 Jul 29, 2020
@samhouts samhouts moved this from In Progress to Done in v4.6.0 Jul 29, 2020
@samhouts samhouts removed this from Done in v4.6.0 Jul 29, 2020
@samhouts samhouts added this to In Progress in v4.6.0 Jul 29, 2020
@samhouts samhouts moved this from In Progress to Done in v4.6.0 Jul 29, 2020
@samhouts samhouts removed this from Done in v4.6.0 Jul 29, 2020
@samhouts samhouts added this to In Progress in v4.6.0 Jul 29, 2020
@samhouts samhouts moved this from In Progress to Done in v4.6.0 Jul 29, 2020
@samhouts samhouts removed this from Done in v4.6.0 Jul 29, 2020
@samhouts samhouts added this to In Progress in v4.6.0 Jul 29, 2020
@samhouts samhouts moved this from In Progress to Done in v4.6.0 Jul 29, 2020
@samhouts samhouts removed this from Done in v4.6.0 Jul 29, 2020
@samhouts samhouts added this to In Progress in v4.6.0 Jul 29, 2020
@samhouts samhouts moved this from In Progress to Done in v4.6.0 Jul 29, 2020
@samhouts samhouts removed this from Done in v4.6.0 Jul 29, 2020
@samhouts samhouts added this to In Progress in v4.6.0 Jul 29, 2020
@samhouts samhouts moved this from In Progress to Done in v4.6.0 Jul 29, 2020
@samhouts samhouts removed this from Done in v4.6.0 Jul 29, 2020
@samhouts samhouts added this to In Progress in v4.6.0 Jul 29, 2020
@samhouts samhouts moved this from In Progress to Done in v4.6.0 Jul 29, 2020
@samhouts samhouts removed this from Done in v4.6.0 Jul 29, 2020
@samhouts samhouts added this to In Progress in v4.6.0 Jul 30, 2020
@samhouts samhouts moved this from In Progress to Done in v4.6.0 Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/frame e/5 🕔 5 in-progress This issue has an associated pull request that may resolve it! p/iOS 🍎 t/bug 🐛
Projects
No open projects
v4.5.0
  
Done
v4.6.0
  
Done
Development

No branches or pull requests

8 participants