This repository has been archived by the owner on May 1, 2024. It is now read-only.
Make Color property work on UWP BoxView #10540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes 10535
2 tasks
|
Should fix #10528 also |
|
@hartez Thanks for fixing my bug, sorry about that! |
No apologies necessary. It's kind of ridiculous that we have two different properties that do the exact same thing; I can't blame someone for forgetting one of them. :)
|
rmarinho
approved these changes
May 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
In the move from using a Rectangle to a Border for UWP's BoxView renderer, the Color property (which does the same thing as the BackgroundColor) was lost. This change restores that property.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Automated test
PR Checklist