This repository has been archived by the owner on May 1, 2024. It is now read-only.
IndicatorView not updating to current page when CarouselView is bound to custom DataType #10589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmarinho
approved these changes
May 7, 2020
samhouts
pushed a commit
that referenced
this pull request
May 7, 2020
* Remove code that adjusts the frame when hiding/showing TabBar * - enable for android * Make cookie handling consistent and non destructive (#10571) fixes #10318 * Make cookie handling consistent and non destructive * - fix ios * - ios fixes * - sync fixes * - ios fixes * - fix ui tests * - fix uwp * - move buttons around * - update comments * - ios10 adjustments * - use host for key not full url * Added repro sample (#10589) fixes #8958 * Fix TemplatedItemsList incorrect grouped collection range removal (#7891) fixes #7890 * fix * test added * uitest added * ui test fix Co-authored-by: melimion <Evlentev@molot.net> * [Tizen] Update ShellRenderer for extend (#10587) * iOS 10 fix for Top Tabs on Shell (#10500) Co-authored-by: Rui Marinho <me@ruimarinho.net> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: melimion <33512073+melimion@users.noreply.github.com> Co-authored-by: melimion <Evlentev@molot.net> Co-authored-by: Seungkeun Lee <sngn.lee@samsung.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com> fixes #10134
samhouts
added
a/indicatorview
blocker
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The problem more than in the IndicatorView is in an error updating the position of the CarouselView. We did changes in the logic to update the CarouselView Position and CurrentItem from 4.4 to 4.6. The issue is fixed in 4.6. Therefore this PR only include a sample to validate the case. @rmarinho Should we update the logic related with CarouselView Position in 4.4 to fix the issue in a 4.4 release?. I have a branch prepared with those changes if necessary.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Testing Procedure
Launch Core Gallery and navigate to the issue 8958. Change the CarouselView Position and verify that the IndicatorView position is updated too.
PR Checklist