Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

PresentsWithGesture incorrectly toggled back to true when Flyout Disabled #10632

Merged
merged 2 commits into from May 12, 2020
Merged

PresentsWithGesture incorrectly toggled back to true when Flyout Disabled #10632

merged 2 commits into from May 12, 2020

Conversation

PureWeen
Copy link
Contributor

Description of Change

On an iPad the PresentsWithGesture is being incorrectly re-enabled when the flyout behavior was set to disabled

Platforms Affected

  • iOS

Testing Procedure

  • On an iPad run the store shell or go to the "shell Flyout Behavior" issue and play with disabling the flyout. Once you've disable it try to swipe it open with a gesture

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@PureWeen PureWeen added blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. 4.6.0 regression on 4.6.0 and removed 4.6.0 regression on 4.6.0 labels May 10, 2020
@PureWeen PureWeen added this to the 4.6.0 milestone May 10, 2020
@PureWeen PureWeen added this to In Review in Shell via automation May 10, 2020
@samhouts samhouts added this to Ready for Review (PRs) in Sprint 170 May 11, 2020
@rmarinho rmarinho merged commit 31da30a into 4.6.0 May 12, 2020
Shell automation moved this from In Review to Done May 12, 2020
Sprint 170 automation moved this from Ready for Review (PRs) to Done May 12, 2020
@PureWeen PureWeen mentioned this pull request May 16, 2020
Closed
@PureWeen PureWeen deleted the ios_gesture_flyout_disabled branch May 16, 2020 21:15
@samhouts samhouts added this to Ready for Review (PRs) in Sprint 171 May 21, 2020
@samhouts samhouts moved this from Ready for Review (PRs) to Done in Sprint 171 May 28, 2020
@samhouts samhouts moved this from Done to Ready for Review (PRs) in Sprint 171 May 28, 2020
@samhouts samhouts moved this from Ready for Review (PRs) to Done in Sprint 171 May 28, 2020
@samhouts samhouts removed this from Done in Shell Jun 11, 2020
@samhouts samhouts added this to Done in v4.6.0 Jun 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

Assignees
No one assigned
Labels
a/shell 🐚 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue.
Projects
No open projects
Sprint 170
  
Done
Sprint 171
  
Done
v4.6.0
  
Done
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PureWeen @rmarinho @jsuarezruiz