Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Android] Fix NRE accessing a disposed SwipeView #10682

Merged
merged 5 commits into from
Aug 18, 2020
Merged

[Android] Fix NRE accessing a disposed SwipeView #10682

merged 5 commits into from
Aug 18, 2020

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Avoid NRE accessing a disposed SwipeView.

Issues Resolved

API Changes

None

Platforms Affected

  • iOS
  • Android

Behavioral/Visual Changes

None

Before/After Screenshots

fix10679

Testing Procedure

Launch Core Gallery and navigate to the issue 10679. Navigate to the second page and the swipe (left or right). If swiping can navigate to another Page without problems, the test has passed.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@haavamoa haavamoa mentioned this pull request May 16, 2020
Closed
@samhouts samhouts added this to In Review in SwipeView May 21, 2020
@samhouts samhouts added the i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often label Jun 8, 2020
@samhouts samhouts added this to In Progress in v4.6.0 Jun 20, 2020
@samhouts samhouts changed the base branch from 4.6.0 to 4.7.0 June 25, 2020 22:24
@samhouts samhouts removed this from In Progress in v4.6.0 Jun 25, 2020
@samhouts samhouts added this to In Progress in 4.7.0 Jun 25, 2020
@samhouts samhouts changed the base branch from 4.7.0 to 4.8.0 July 8, 2020 18:12
@samhouts samhouts removed this from In Progress in 4.7.0 Jul 8, 2020
@samhouts samhouts added this to In Progress in vCurrent (4.8.0) Jul 30, 2020
@PureWeen PureWeen added the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Jul 30, 2020
@samhouts samhouts added this to the 5.0.0 milestone Aug 4, 2020
@samhouts samhouts added the retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. label Aug 4, 2020
@samhouts samhouts changed the base branch from 4.8.0 to 5.0.0 August 4, 2020 22:23
@samhouts samhouts removed the retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. label Aug 4, 2020
@samhouts
Copy link
Member

samhouts commented Aug 4, 2020

@jsuarezruiz It looks like this was already resolved? #10679

@samhouts samhouts removed this from In Progress in vCurrent (4.8.0) Aug 4, 2020
@samhouts samhouts added this to In Progress in vNext+1 (5.0.0) Aug 11, 2020
@jsuarezruiz jsuarezruiz removed the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Aug 18, 2020
@samhouts samhouts merged commit f5575fb into 5.0.0 Aug 18, 2020
SwipeView automation moved this from In Review to Done Aug 18, 2020
vNext+1 (5.0.0) automation moved this from In Progress to Done Aug 18, 2020
@samhouts samhouts deleted the fix-10679 branch August 18, 2020 16:41
@samhouts samhouts added this to Done in Sprint 175 Aug 24, 2020
@samhouts samhouts removed this from Done in SwipeView Nov 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PureWeen PureWeen PureWeen requested changes

@rmarinho rmarinho Awaiting requested review from rmarinho

Assignees

@rmarinho rmarinho

@PureWeen PureWeen

Labels
a/navigation a/swipeview i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often p/Android p/iOS 🍎 t/bug 🐛
Projects
No open projects
Sprint 175
  
Done
vNext+1 (5.0.0)
Done
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jsuarezruiz @samhouts @PureWeen @rmarinho