This repository has been archived by the owner on May 1, 2024. It is now read-only.
Avoid NullReferenceException for MaterialActivityIndicatorRenderer #10747
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under some conditions, possibly related to
ActivityIndicator
visibility,Control
may be null at time of call toLayoutSubviews()
. This caused crash due toNullReferenceException
. This null check avoids that problem.Note: this is the second PR for the same; was accidentally merging from master to 4.6.0 on the first one.
Description of Change
Null check for
Control
inXamarin.Forms.Material.iOS.MaterialActivityIndicatorRenderer.LayoutSubviews()
Issues Resolved
I noticed that at times I was seeing crashes due to
NullReferenceException
following Shell'sGoToAsync
method. On further investigation it was due to attempted access on a nullControl
. This null check solved the problem.API Changes
None.
Platforms Affected
Behavioral/Visual Changes
Resolution of
NullReferenceException
crashesBefore/After Screenshots
Not applicable
Testing Procedure
I wasn't able to come up with a simple repro, however the issue was reliably reproducible in my production app. It occurred on returning to a
ShellItem
viaGoToAsync
for a second time. May have something to do withActivityIndicator
visibility.PR Checklist