Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Android] Fix issue animating StrokeDashOffset #11046

Merged
merged 1 commit into from Jul 2, 2020
Merged

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Jun 15, 2020

Description of Change

Fix issue animating StrokeDashOffset.

Issues Resolved

API Changes

None

Platforms Affected

  • Android

Behavioral/Visual Changes

None

Before/After Screenshots

Before

Animation did not work on Android.

After

animate-shape

Testing Procedure

Launch Core Gallery and navigate to the Shapes Gallery. Select the "Animate Shape Gallery" and verify that the shape is animating.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@jsuarezruiz jsuarezruiz changed the title [Android] Fix issue animating StrokeDashOffset in Android [Android] Fix issue animating StrokeDashOffset Jun 15, 2020
@samhouts samhouts changed the base branch from master to 4.8.0 June 26, 2020 00:01
@samhouts samhouts added the approved Has two approvals, no pending reviews, and no changes requested label Jun 30, 2020
@samhouts samhouts merged commit 0da3de7 into 4.8.0 Jul 2, 2020
@samhouts samhouts deleted the animate-shape branch July 2, 2020 17:12
@samhouts samhouts added this to the 4.8.0 milestone Jul 14, 2020
@samhouts samhouts added this to Done in vCurrent (4.8.0) Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/animation 🎬 Animation stuff a/shapes approved Has two approvals, no pending reviews, and no changes requested ControlGallery p/Android t/bug 🐛
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[Bug][Android] Shapes: Moving spiral demo doesn't animate on Android
3 participants