[Android] Fix exception removing item from CarouselView #11074
Conversation
jsuarezruiz
added
t/bug 🐛
p/Android
i/high
| } | ||
|
|
||
| [Preserve(AllMembers = true)] | ||
| public class Issue10865ViewModel |
There was a problem hiding this comment.
This test could be automated.
There was a problem hiding this comment.
In fact, since it's just a test of GetPosition, it could just be a platform test; no UI test necessary.
There was a problem hiding this comment.
Also, the test instructions do not match the instructions from the original issue.
There was a problem hiding this comment.
Right, added unit test.
There was a problem hiding this comment.
Unit test looks good, can we just remove this screen entirely?
There was a problem hiding this comment.
Sure, I can remove it, but, why not leave the screen next to the test?
There was a problem hiding this comment.
Because it's one more screen that we have to maintain as things change, and one more class/screen to load every time we load the solution or test.
| } | ||
|
|
||
| [Preserve(AllMembers = true)] | ||
| public class Issue10865ViewModel |
There was a problem hiding this comment.
Unit test looks good, can we just remove this screen entirely?
Description of Change
Fix exception removing item from
CarouselViewon Android.Deleting items (or adding) sets the CarouselView
CurrentItem. To update the current item, we use the IItemsViewSourceGetItemmethod that gets the item based on the position. The error was that the position value was -1 (incorrect) because the comparison of items made in the IItemsViewSourceGetPositionmethod was incorrect.NOTE: Tested the same on iOS and is working without problems.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Before
Crash! (Add Item, remove it and try to add again).
After
Testing Procedure
Launch Core Gallery and navigate to the issue10865. Click add until you have more than one item, then scroll to the last item and remove the last item. Without exception, the test has passed.
PR Checklist