This repository has been archived by the owner on May 1, 2024. It is now read-only.
[X] throw on mismatching param type for Add() #11086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samhouts
added
a/Xaml </>
feedback-ticket
StephaneDelcroix
force-pushed
the
fix_gh11061
branch
2 times, most recently
from
b5dc3c8
to
dee59f4
Compare
There was a `TODO: check parameter type` in this code, like if past me knew that, at some point in time, what was only a potential edge case bug, would explode in my face and ruin my faith in humanity. Those FIXMEs... they are bottled 'I TOLD YOU SO' little time capsules - fixes #11061
StephaneDelcroix
force-pushed
the
fix_gh11061
branch
from
dee59f4
to
8de4028
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
There was a
TODO: check parameter typein this code, like if past meknew that, at some point in time, what was only a potential edge case
bug, would explode in my face and ruin my faith in humanity.
Those FIXMEs... they are bottled 'I TOLD YOU SO' little time capsules
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
PR Checklist