Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[iOS] Fix Path Transformations issue #11110

Merged
merged 8 commits into from
Jul 16, 2020
Merged

[iOS] Fix Path Transformations issue #11110

merged 8 commits into from
Jul 16, 2020

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Jun 18, 2020

Description of Change

The issue had small problems:

  • Drawing error on iOS: The problem was in the conversion of StrokeDash. Fixed.
  • The clock was not moving. Fixed, was a problem applying an incorrect transformation to Path.
  • Android drawing error: I have verified that this is the same issue as [Bug][Android] Shapes: flower not drawing correctly on Android #11048. It will be fixed when send a PR to fix that issue (very soon).

Issues Resolved

API Changes

None

Platforms Affected

  • Core/XAML (all platforms)
  • iOS

Behavioral/Visual Changes

None

Before/After Screenshots

fix-11050

Testing Procedure

Launch Core Gallery and navigate to the issue 11050. If the Clock is rendering without problems and is working (the hands of the clock move), the test has passed.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@samhouts
Copy link
Member

@jsuarezruiz please rebase & start tests. thanks!

@samhouts samhouts added the approved Has two approvals, no pending reviews, and no changes requested label Jun 30, 2020
@samhouts samhouts changed the base branch from 4.7.0 to 4.8.0 July 8, 2020 18:13
@samhouts samhouts removed this from In Review in 4.7.0 Jul 8, 2020
@samhouts samhouts merged commit e1bcaa3 into 4.8.0 Jul 16, 2020
@samhouts samhouts deleted the fix-11050 branch July 16, 2020 23:17
@samhouts samhouts added this to Done in Sprint 173 Jul 17, 2020
@samhouts samhouts added this to the 4.8.0 milestone Jul 23, 2020
@samhouts samhouts added this to Done in vCurrent (4.8.0) Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/shapes approved Has two approvals, no pending reviews, and no changes requested Core p/iOS 🍎 t/bug 🐛
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants