Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[iOS] Fix issue hiding NavigationBarSeparator #11165

Merged
merged 5 commits into from
Jul 13, 2020
Merged

[iOS] Fix issue hiding NavigationBarSeparator #11165

merged 5 commits into from
Jul 13, 2020

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Issues Resolved

API Changes

None

Platforms Affected

  • iOS

Behavioral/Visual Changes

None

Before/After Screenshots

Simulator Screen Shot - iPhone 11 - 2020-06-22 at 12 47 32

Testing Procedure

Launch Core Gallery and navigate to the issue 9456. If the NavigationBarSeparator is hidden, the test has passed.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@samhouts samhouts added this to In Review in 4.7.0 Jun 22, 2020
@samhouts samhouts added the retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. label Jun 22, 2020
@samhouts samhouts added this to Ready for Review (PRs) in Sprint 172 Jun 22, 2020
@samhouts samhouts requested review from hartez and samhouts June 23, 2020 22:52
@rmarinho rmarinho linked an issue Jun 24, 2020 that may be closed by this pull request
[Bug] navPage.SetHideNavigationBarSeparator(true) no longer works. #9456
Closed
@samhouts
Copy link
Member

so does this regress #9767?

@samhouts samhouts added retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. and removed retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. labels Jun 25, 2020
@hartez
Copy link
Contributor

hartez commented Jul 2, 2020

so does this regress #9767?

Looks like the fix for 9767 is still working.

@samhouts samhouts added this to Ready for Review (PRs) in Sprint 173 Jul 2, 2020
@samhouts samhouts moved this from Ready for Review (PRs) to Continued in next sprint in Sprint 172 Jul 6, 2020
@samhouts samhouts removed the retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. label Jul 6, 2020
@samhouts samhouts added the approved Has two approvals, no pending reviews, and no changes requested label Jul 7, 2020
@samhouts samhouts merged commit aeff6e1 into 4.7.0 Jul 13, 2020
4.7.0 automation moved this from In Review to Done Jul 13, 2020
Sprint 173 automation moved this from Ready for Review (PRs) to Done Jul 13, 2020
@samhouts samhouts deleted the fix-9456 branch July 13, 2020 17:42
@samhouts samhouts modified the milestones: 4.8.0, 4.7.0 Jul 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hartez hartez hartez approved these changes

@samhouts samhouts samhouts approved these changes

Assignees

@hartez hartez

@samhouts samhouts

Labels
4.5.0 regression on 4.5.0 a/navbar approved Has two approvals, no pending reviews, and no changes requested i/regression iOS 13 m/high impact ⬛ p/iOS 🍎 platform-specifics t/bug 🐛
Projects
No open projects
4.7.0
  
Done
Sprint 172
  
Continued in next sprint
Sprint 173
  
Done
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.

[Bug] navPage.SetHideNavigationBarSeparator(true) no longer works.
3 participants
@jsuarezruiz @samhouts @hartez