Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[iOS] Fix Gesture issue with SwipeView #11217

Merged
merged 7 commits into from
Sep 7, 2020
Merged

[iOS] Fix Gesture issue with SwipeView #11217

merged 7 commits into from
Sep 7, 2020

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Fix Gesture issue with SwipeView.

Issues Resolved

API Changes

None

Platforms Affected

  • iOS

Behavioral/Visual Changes

None

Before/After Screenshots

fix11209

Testing Procedure

Launch Core Gallery and navigate to the issue 11209. Tap any item from the list. If navigate to another page, the test has passed.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@samhouts samhouts added this to In Review in 4.7.0 Jun 26, 2020
@samhouts samhouts added this to In Review in SwipeView Jun 29, 2020
@samhouts samhouts requested review from hartez and PureWeen June 30, 2020 23:44
@samhouts samhouts changed the base branch from 4.7.0 to 4.8.0 July 8, 2020 17:54
@samhouts samhouts added the Core label Jul 8, 2020
@samhouts samhouts removed this from In Review in 4.7.0 Jul 8, 2020
@samhouts samhouts added this to In Review in vCurrent (4.8.0) Jul 30, 2020
@samhouts samhouts added this to the 5.0.0 milestone Aug 4, 2020
@samhouts samhouts added the retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. label Aug 4, 2020
@samhouts samhouts changed the base branch from 4.8.0 to 5.0.0 August 4, 2020 22:23
@samhouts samhouts removed the retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. label Aug 4, 2020
@samhouts samhouts removed this from In Review in vCurrent (4.8.0) Aug 4, 2020
@samhouts samhouts added this to In Review in vNext+1 (5.0.0) Aug 11, 2020
PureWeen
PureWeen suggested changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@PureWeen PureWeen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised

Can you add a UI Test?

WORD UP
image

@PureWeen PureWeen added the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Aug 14, 2020
@jsuarezruiz
Copy link
Contributor Author

Added UITest.

@jsuarezruiz jsuarezruiz removed the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Aug 18, 2020
@rmarinho rmarinho merged commit 0fdeee5 into 5.0.0 Sep 7, 2020
SwipeView automation moved this from In Review to Done Sep 7, 2020
vNext+1 (5.0.0) automation moved this from In Review to Done Sep 7, 2020
@rmarinho rmarinho deleted the fix-11209 branch September 7, 2020 11:04
@samhouts samhouts added this to Done in Sprint 176 Sep 8, 2020
@samhouts samhouts removed this from Done in SwipeView Nov 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

@PureWeen PureWeen PureWeen approved these changes

@hartez hartez Awaiting requested review from hartez

Assignees

@hartez hartez

@PureWeen PureWeen

Labels
a/swipeview Core p/iOS 🍎 t/bug 🐛
Projects
No open projects
Sprint 176
  
Done
vNext+1 (5.0.0)
Done
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jsuarezruiz @rmarinho @PureWeen @hartez @samhouts