Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Android] Fix setting the CarouselView position while control isn't visible #11239

Merged
merged 6 commits into from
Jul 20, 2020

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Issues Resolved

API Changes

None

Platforms Affected

  • Android

Behavioral/Visual Changes

None

Before/After Screenshots

Screenshot_1593426748

Testing Procedure

Launch Core Gallery and navigate to the issue 11224. Tap the Button. If the item selected in the CarouselView is Item 4, the test has passed.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@samhouts samhouts changed the base branch from 4.7.0 to 4.8.0 July 8, 2020 17:54
@samhouts samhouts removed this from In Review in 4.7.0 Jul 8, 2020
@samhouts samhouts added this to In Review in CollectionView Jul 13, 2020
@samhouts samhouts added this to In Review in CarouselView Jul 13, 2020
@samhouts
Copy link
Member

@jsuarezruiz Can you please rebase this on 4.8.0 to get rid of the extra commits? Thanks!

@jsuarezruiz
Copy link
Contributor Author

@samhouts Done!

@samhouts samhouts added the approved Has two approvals, no pending reviews, and no changes requested label Jul 16, 2020
@samhouts samhouts merged commit 8c63ee7 into 4.8.0 Jul 20, 2020
CollectionView automation moved this from In Review to Done Jul 20, 2020
CarouselView automation moved this from In Review to Done Jul 20, 2020
@samhouts samhouts deleted the fix-11224 branch July 20, 2020 20:32
@samhouts samhouts added this to Done in Sprint 173 Jul 21, 2020
@samhouts samhouts added this to the 4.8.0 milestone Jul 23, 2020
@samhouts samhouts added this to Done in vCurrent (4.8.0) Jul 30, 2020
@samhouts samhouts removed this from Done in CollectionView Aug 19, 2020
@samhouts samhouts removed this from Done in CarouselView Aug 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/carouselview a/collectionview approved Has two approvals, no pending reviews, and no changes requested Core p/Android p/iOS 🍎 t/bug 🐛
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants