Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Android] Fix issue in SwipeView using TapGestureRecognizer #11340

Merged
merged 5 commits into from
Aug 17, 2020
Merged

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Fix issue in SwipeView if child has TapGestureRecognizer on Android.

Issues Resolved

API Changes

None

Platforms Affected

  • Android

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

Launch Core Gallery and navigate to the issue 11333. Swipe to the left any item. If can swipe the test has passed

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@samhouts samhouts added this to In Review in 4.7.0 Jul 7, 2020
@samhouts samhouts requested review from hartez and samhouts July 7, 2020 18:45
@samhouts samhouts changed the base branch from 4.7.0 to 4.8.0 July 8, 2020 17:09
@samhouts samhouts removed this from In Review in 4.7.0 Jul 8, 2020
@samhouts samhouts added this to In Review in SwipeView Jul 13, 2020
@samhouts samhouts added this to In Review in vCurrent (4.8.0) Jul 30, 2020
@samhouts samhouts added this to the 5.0.0 milestone Aug 4, 2020
@samhouts samhouts added the retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. label Aug 4, 2020
@samhouts samhouts changed the base branch from 4.8.0 to 5.0.0 August 4, 2020 22:21
@samhouts samhouts removed the retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. label Aug 4, 2020
@samhouts samhouts removed this from In Review in vCurrent (4.8.0) Aug 4, 2020
@samhouts samhouts added this to In Review in vNext+1 (5.0.0) Aug 11, 2020
@samhouts samhouts merged commit c8f039d into 5.0.0 Aug 17, 2020
SwipeView automation moved this from In Review to Done Aug 17, 2020
vNext+1 (5.0.0) automation moved this from In Review to Done Aug 17, 2020
@samhouts samhouts deleted the fix-11333 branch August 17, 2020 17:50
@samhouts samhouts added this to Done in Sprint 175 Aug 17, 2020
myroot pushed a commit to myroot/Xamarin.Forms that referenced this pull request Aug 19, 2020
Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com>
fixes xamarin#11333
sung-su pushed a commit to sung-su/Xamarin.Forms that referenced this pull request Aug 20, 2020
Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com>
fixes xamarin#11333
sung-su pushed a commit to sung-su/Xamarin.Forms that referenced this pull request Aug 20, 2020
Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com>
fixes xamarin#11333
@samhouts samhouts removed this from Done in SwipeView Nov 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants