Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BoostrapHelper #11400

Merged
merged 1 commit into from Jul 16, 2020
Merged

Add BoostrapHelper #11400

merged 1 commit into from Jul 16, 2020

Conversation

maxbrister
Copy link
Contributor

@maxbrister maxbrister commented Jul 10, 2020 •
edited by StephaneDelcroix

Description of Change

Enable C++ code to simulate ICLRRuntimeHost2::ExecuteAssembly on top of ICLRRuntimeHost2::CreateDelegate in .net core 2.

Issues Resolved

None

API Changes

None

Platforms Affected

  • UWP

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

Validated locally that C++ code can use BoostrapHelper.Bootstrap to load a managed dll.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

VS bug #1156448

@dnfadmin
Copy link

dnfadmin commented Jul 10, 2020 •
edited

CLA assistant check
All CLA requirements met.

@samhouts samhouts added the p/UWP label Jul 10, 2020
@StephaneDelcroix StephaneDelcroix added i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often external-hotreload Non-Forms bugs that affect Hot Reload m/high impact ⬛ labels Jul 14, 2020
@maxbrister maxbrister merged commit 05079b1 into xamarin:4.8.0 Jul 16, 2020
@samhouts samhouts added this to Done in Sprint 173 Jul 16, 2020
@maxbrister maxbrister deleted the uwp-bootstrap branch July 23, 2020 02:31
@samhouts samhouts added this to the 4.8.0 milestone Jul 23, 2020
@samhouts samhouts added this to Done in vCurrent (4.8.0) Jul 30, 2020
@eerhardt eerhardt mentioned this pull request Mar 17, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephaneDelcroix StephaneDelcroix StephaneDelcroix approved these changes

@jsuarezruiz jsuarezruiz Awaiting requested review from jsuarezruiz

@samhouts samhouts Awaiting requested review from samhouts

Assignees

@StephaneDelcroix StephaneDelcroix

@jsuarezruiz jsuarezruiz

@samhouts samhouts

Labels
external-hotreload Non-Forms bugs that affect Hot Reload i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often m/high impact ⬛ p/UWP
Projects
No open projects
Sprint 173
  
Done
vCurrent (4.8.0)
  
Done
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@maxbrister @dnfadmin @StephaneDelcroix @jsuarezruiz @samhouts