This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Android, iOS] Fixed issue rendering Rectangle using Radius #11418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samhouts
approved these changes
Jul 13, 2020
samhouts
added
the
i/high
|
@jsuarezruiz Please fix the conflicts! Thanks! |
rmarinho
approved these changes
Jul 30, 2020
samhouts
added
the
approved
myroot
pushed a commit
to myroot/Xamarin.Forms
that referenced
this pull request
Aug 19, 2020
…11418) * Added repro sample * Fixed issue on Android * Fixed the issue on iOS * Fixed build error * [iOS] Fix rebase Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> fixes xamarin#11413
sung-su
pushed a commit
to sung-su/Xamarin.Forms
that referenced
this pull request
Aug 20, 2020
…11418) * Added repro sample * Fixed issue on Android * Fixed the issue on iOS * Fixed build error * [iOS] Fix rebase Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> fixes xamarin#11413
sung-su
pushed a commit
to sung-su/Xamarin.Forms
that referenced
this pull request
Aug 20, 2020
…11418) * Added repro sample * Fixed issue on Android * Fixed the issue on iOS * Fixed build error * [iOS] Fix rebase Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> fixes xamarin#11413
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixed issue rendering Rectangle using RadiusX and RadiusY. The problem was assigning a radius before setting the size of the rectangle.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Testing Procedure
Launch Core Gallery and navigate to the issue 11413. If a black square with corner radius is rendered inside a red rectangle, the test has passed.
PR Checklist