This repository has been archived by the owner on May 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
added
the
DO-NOT-MERGE-!!! 🛑
This is in progress and needs to be updated before it can be merged.
label
Jul 24, 2020
Testing a comment |
PureWeen
added
blocker
Issue blocks next stable release. Prioritize fixing and reviewing this issue.
and removed
DO-NOT-MERGE-!!! 🛑
This is in progress and needs to be updated before it can be merged.
labels
Jul 24, 2020
samhouts
added
a/DragAndDrop
API-change
Heads-up to reviewers that this PR may contain an API change
a/gestures 🖖
proposal-accepted
roadmap
and removed
proposal-open
labels
Jul 27, 2020
Should you have a null image source? No. Was it the first thing I tried? Yes. <Image x:Name="Image" Margin="10,292,10,0" HeightRequest="338" BackgroundColor="Aqua">
<Image.GestureRecognizers>
<DragGestureRecognizer CanDrag="True"></DragGestureRecognizer>
</Image.GestureRecognizers>
</Image>
|
Works great on Android. |
samhouts
reviewed
Jul 28, 2020
Xamarin.Forms.Controls/GalleryPages/DragAndDropGalleries/EnablingAndDisablingGestureTests.cs
Outdated
Show resolved
Hide resolved
…ingAndDisablingGestureTests.cs Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com>
samhouts
approved these changes
Jul 29, 2020
@PureWeen I really like this API. I've been using it a little bit on UWP and it seems very solid :) (I've posted one issue around the UWP cursor and a docs issue around how to use commands but other than that it is pretty great!) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
a/DragAndDrop
a/gestures 🖖
API-change
Heads-up to reviewers that this PR may contain an API change
blocker
Issue blocks next stable release. Prioritize fixing and reviewing this issue.
ControlGallery
m/high impact ⬛
p/Android
p/iOS 🍎
p/UWP
proposal-accepted
roadmap
t/enhancement ➕
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Preview release of Drag and Drop
FYI only works on iOS11+ because that's when the drag and drop apis were added
Issues Resolved
API Changes
DropGestureRecognizer
DragGestureRecognizer
DragItemsStartingEventArgs
DataPackageOperation
DragEventArgs
DropCompletedEventArgs
DropEventArgs
DataPackage
This is used to setup the data for transfer
DataPackageView
This is a read-only copy of the DataPackage object.
This is all the user gets on the drop event to retrieve the data. They can't modify the package
Platforms Affected
Testing Procedure
PR Checklist