Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Shell FlyoutBackdrop now with Brushes!! #11580

Merged
merged 7 commits into from
Jul 28, 2020
Merged

Shell FlyoutBackdrop now with Brushes!! #11580

merged 7 commits into from
Jul 28, 2020

Conversation

PureWeen
Copy link
Contributor

@PureWeen PureWeen commented Jul 27, 2020 •
edited
Loading

Description of Change

Add FlyoutBackdrop back into Shell but now based on Brushes

#10511

API Changes

Added:

  • Brush ShellAppearance.FlyoutBackdrop

Platforms Affected

  • iOS
  • Android
  • UWP

Before/After Screenshots

Android

6F1D65D4-DD8E-4C3B-A7FD-116E42C857C9

Testing Procedure

  • play with store shell

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@samhouts samhouts added the blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. label Jul 27, 2020
@samhouts samhouts added this to Ready for Review (PRs) in Sprint 174 via automation Jul 27, 2020
rmarinho
rmarinho approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, just a couple of comments.

Xamarin.Forms.Platform.UAP/Shell/ShellSplitView.cs Outdated Show resolved Hide resolved
Xamarin.Forms.Platform.UAP/Shell/ShellRenderer.cs Show resolved Hide resolved
@samhouts samhouts merged commit d32b115 into 4.8.0 Jul 28, 2020
Sprint 174 automation moved this from Ready for Review (PRs) to Done Jul 28, 2020
@samhouts samhouts deleted the shell_flyoutbackdrop branch July 28, 2020 22:50
@samhouts samhouts added the approved Has two approvals, no pending reviews, and no changes requested label Jul 29, 2020
@samhouts samhouts added this to Done in vCurrent (4.8.0) Jul 30, 2020
@samhouts samhouts added this to the 4.8.0 milestone Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

@samhouts samhouts samhouts approved these changes

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix is a code owner

Assignees

@rmarinho rmarinho

@samhouts samhouts

Labels
a/shell 🐚 approved Has two approvals, no pending reviews, and no changes requested blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. ControlGallery p/Android p/iOS 🍎 p/UWP
Projects
No open projects
Sprint 174
  
Done
vCurrent (4.8.0)
  
Done
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PureWeen @rmarinho @samhouts