This repository has been archived by the owner on May 1, 2024. It is now read-only.
Make core Ticker abstract and public #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the core Ticker abstract and public so it can be inherited by platform implementations; remove now-unused parts of original Ticker; add CreateTicker to IPlatformServices; remove unused CreateTimer methods from IPlatformServices
hartez
changed the title
hartez
changed the title
| //ITimer CreateTimer(Action<object> callback, object state, int dueTime, int period); | ||
| //ITimer CreateTimer(Action<object> callback, object state, long dueTime, long period); | ||
| //ITimer CreateTimer(Action<object> callback, object state, TimeSpan dueTime, TimeSpan period); | ||
| //ITimer CreateTimer(Action<object> callback, object state, uint dueTime, uint period); | ||
|
|
|
👍 |
This was referenced Jun 1, 2020
mattleibow
pushed a commit
that referenced
this pull request
Jan 28, 2021
* Add initial compass API with samples * Update Compass to new API and add CompassData return types. * Add xunit tests * Add compass tests and documentation * Made adjustments based on feedback to cleanup code. * Fix samples! Rename everywhere seemed to have failed :( * Fix build * Fix build again. * Tweaked the sample VM a bit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Make the core Ticker abstract and public so it can be inherited by platform
implementations; remove now-unused parts of original Ticker; add CreateTicker
to IPlatformServices; remove unused CreateTimer methods from IPlatformServices
No tests; this is mostly just removing old unused code.
API Changes
None
Behavioral Changes
None
PR Checklist