Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Don't update safe area offset on non visible page #11602

Merged
merged 1 commit into from Aug 4, 2020
Merged

Don't update safe area offset on non visible page #11602

merged 1 commit into from Aug 4, 2020

Conversation

PureWeen
Copy link
Contributor

Description of Change

  • the ios page renderer when disappearing was still propagating its inset information to shell which was causing a ping pong effect
  • Automation properties weren't being set on top tabs

Issues Resolved

Platforms Affected

  • iOS
  • Android

Testing Procedure

  • ui tests included

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@samhouts samhouts added this to In Review in 4.7.0 Jul 30, 2020
@samhouts samhouts added this to Ready for Review (PRs) in Sprint 174 Jul 30, 2020
@rmarinho
Copy link
Member

rmarinho commented Aug 4, 2020

Failing tests don't seem related

@PureWeen PureWeen added the blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. label Aug 4, 2020
@samhouts samhouts merged commit b38d590 into 4.7.0 Aug 4, 2020
4.7.0 automation moved this from In Review to Done Aug 4, 2020
Sprint 174 automation moved this from Ready for Review (PRs) to Done Aug 4, 2020
@samhouts samhouts deleted the fix_10608 branch August 4, 2020 21:01
@samhouts samhouts added the approved Has two approvals, no pending reviews, and no changes requested label Aug 5, 2020
@samhouts samhouts added this to the 4.7.0 milestone Aug 5, 2020
@PureWeen PureWeen mentioned this pull request Aug 5, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

@samhouts samhouts samhouts approved these changes

Assignees

@rmarinho rmarinho

@samhouts samhouts

Labels
a/shell 🐚 approved Has two approvals, no pending reviews, and no changes requested blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. p/Android p/iOS 🍎 partner/cat 😻 t/bug 🐛
Projects
No open projects
4.7.0
  
Done
Sprint 174
  
Done
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PureWeen @rmarinho @samhouts