This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Core] Add extra method that allows to specify default value for CanExecute on a Command #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (cmd != null) | ||
| IsEnabledCore = cmd.CanExecute(CommandParameter); | ||
| if(cmd != null) | ||
| IsEnabledCore = (cmd as Command)?.CanExecute(CommandParameter, IsEnabled) ?? cmd.CanExecute(CommandParameter); |
There was a problem hiding this comment.
this makes a lot of assumptions
StephaneDelcroix
suggested changes
Oct 5, 2017
mattleibow
pushed a commit
that referenced
this pull request
Jan 28, 2021
…ic reference systems * see issue #1177 * also mention altitude in Location summary * and fix a typo
mattleibow
pushed a commit
that referenced
this pull request
Jan 28, 2021
* Location: add a new member 'AltitudeReferenceSystem' * and a new enum that represents its type * in order to deal with platform-specific reference systems * see issue #1177 * add documentation for Location.AltitudeReferenceSystem * and the new enum AltitudeReferenceSystem * Samples: show 'Location.AltitudeReferenceSystem' on GeolocationPage * add explicit cast for AltitudeReferenceSystem on UWP * casting from Windows.Devices.Geolocation.AltitudeReferenceSystem to Xamarin.Essentials.AltitudeReferenceSystem * add a conversion function for AltitudeReferenceSystem on UWP * in order to make sure that the cast from Windows.Devices.Geolocation.AltitudeReferenceSystem is valid * Cleanup converstion of ARS for UWP Co-authored-by: James Montemagno <james.montemagno@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This pr resolves a issue where our
CanExecute(obj)method on theCommandwill always return true if aCanExecutedelegate wasn't specified.The problem happens that in a
Buttonwe don't have no way to figure if a user specified or not that delegate on aCommand, and we need to decide to either respect the IsEnabled property from the button or the result of the command can execute.Bugs Fixed
API Changes
Adding to
CommandAdded:
Behavioral Changes
None
PR Checklist