This repository has been archived by the owner on May 1, 2024. It is now read-only.
When navigating between Shell Items disconnect the renderers from the xplat elements #11791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
added
a/shell 🐚
blocker
PureWeen
added
the
DO-NOT-MERGE-!!! 🛑
PureWeen
removed
the
DO-NOT-MERGE-!!! 🛑
|
iOS run of tests here all passed API 19 failure is most likely unrelated but I'm rerunning that one currently |
samhouts
approved these changes
Aug 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When you navigate between FlyoutIItems on shell it uses a transition which doesn't dispose of the previous items until after the transition. If the user navigates between Flyout Items too quickly the previous animation hasn't completed so the renderer stack hasn't disposed. Because the renderer stack hasn't disposed the old renderers are still part of the old pages which causes a doubling up of renderers on the same page.
This PR attempts to disconnect all the communication points between the xplat components and the native components so that the native components can just finish their business in isolation without triggering any behavior from the xplat side of the code.
Issues Resolved
Platforms Affected
Testing Procedure
PR Checklist