Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Tizen] CollectionView enhancement #11820

Merged
merged 1 commit into from
Aug 20, 2020
Merged

[Tizen] CollectionView enhancement #11820

merged 1 commit into from
Aug 20, 2020

Conversation

myroot
Copy link
Contributor

@myroot myroot commented Aug 18, 2020 •
edited
Loading

Description of Change

CollectionView enhancement on Tizen platform

  • Implement Header/footer on CollectionView
  • Implement VisibleViews on CarouselView
  • Implement RemainingItemsThreshold on ItemsView
  • Fix ItemsView.Scrolled Event behavior
    • ItemsView.Scolled event was raised when scrolling was completed

Issues Resolved

  • fixes #

API Changes

Added:

  • object StructuredItemsView.Header
  • object StructuredItemsView.Footer
  • DataTemplate StructuredItemsView.HeaderTemplate
  • DataTemplate StructuredItemsView.FooterTemplate
  • ObservableCollection CarouselView.VisibleViews
  • int ItemsView.RemainingItemsThreshold
  • ICommand ItemsView.RemainingItemsThresholdReachedCommand
  • object ItemsView.RemainingItemsThresholdReachedCommandParameter

Platforms Affected

  • Tizen

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@rookiejava rookiejava self-requested a review August 18, 2020 01:49
@samhouts samhouts added this to In Review in vNext+1 (5.0.0) Aug 18, 2020
@rookiejava rookiejava mentioned this pull request Aug 18, 2020
Merged
2 tasks
rookiejava
rookiejava approved these changes Aug 18, 2020
View reviewed changes
Copy link
Collaborator

@rookiejava rookiejava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing done!

@samhouts samhouts changed the base branch from 5.0.0 to 4.8.0 August 18, 2020 21:43
@samhouts samhouts changed the base branch from 4.8.0 to 5.0.0 August 18, 2020 21:46
@rookiejava
Copy link
Collaborator

@myroot, can you rebase onto 4.8.0?

@myroot myroot changed the base branch from 5.0.0 to 4.8.0 August 19, 2020 23:01
@myroot myroot changed the base branch from 4.8.0 to 5.0.0 August 19, 2020 23:01
@myroot myroot force-pushed the tizen-collectionview-enhancement branch from bb33826 to ce15288 Compare August 19, 2020 23:03
@myroot myroot changed the base branch from 5.0.0 to 4.8.0 August 19, 2020 23:03
@myroot
[Tizen] CollectionView enhancement
3e1c08c 
 - Implement Header/footer
 - Implement VisibleViews on CarouselView
 - Implement RemainingItemsThreshold on ItemsView
 - Fix ItemsView.Scrolled Event behavior
@myroot myroot force-pushed the tizen-collectionview-enhancement branch from ce15288 to 3e1c08c Compare August 19, 2020 23:05
@samhouts samhouts added this to In Review in vCurrent (4.8.0) Aug 19, 2020
@samhouts samhouts removed this from In Review in vNext+1 (5.0.0) Aug 19, 2020
@rmarinho
Copy link
Member

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@rmarinho rmarinho merged commit 50cc3a8 into xamarin:4.8.0 Aug 20, 2020
vCurrent (4.8.0) automation moved this from In Review to Done Aug 20, 2020
@samhouts samhouts added this to Done in Sprint 175 Aug 24, 2020
@samhouts samhouts added this to the 4.8.0 milestone Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rookiejava rookiejava rookiejava approved these changes

@jsuarezruiz jsuarezruiz Awaiting requested review from jsuarezruiz

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix

Assignees
No one assigned
Labels
a/carouselview a/collectionview p/Tizen
Projects
No open projects
Sprint 175
  
Done
vCurrent (4.8.0)
  
Done
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@myroot @rookiejava @rmarinho @samhouts