Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Duo SDK memory leak and Performance fixes #11837

Merged
merged 1 commit into from
Aug 27, 2020
Merged

Duo SDK memory leak and Performance fixes #11837

merged 1 commit into from
Aug 27, 2020

Conversation

PureWeen
Copy link
Contributor

Description of Change

  • added a sample with nesting a TPV into a CV to really push the TPV and make sure it doesn't deadlock and resources clean up
  • updated the dualscreen gallery to latest androidx bits
  • Fixed spanning bounds to compare the rectangles so it doesn't fire too many property changed events
  • Wired up weakeventmanagers, weakreferences, and conditionalweaktables everywhere on android so that dual layout monitoring doesn't cause renderers to stick around in memory
  • Fixed duo services to still report back landscape changes correctly even when not on duo devices
  • Changed all properties that use the ScreenHelper to just set once opposed to reaching over the bridge with every request
  • Moved all the enums out to their own files

Platforms Affected

  • Core/XAML (all platforms)
  • iOS
  • Android
  • UWP

Testing Procedure

  • Run the DualScreen.SLN and you can test out the TwoPaneView from there. You might have to compile some of the platform projects individually because of multitargeting

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@samhouts samhouts added the API-change Heads-up to reviewers that this PR may contain an API change label Aug 25, 2020
@PureWeen PureWeen merged commit af92cb6 into 5.0.0 Aug 27, 2020
vNext+1 (5.0.0) automation moved this from In Review to Done Aug 27, 2020
@PureWeen PureWeen deleted the duo_fixes branch August 27, 2020 20:06
@samhouts samhouts added this to Done in Sprint 175 Aug 27, 2020
@samhouts samhouts added this to the 5.0.0 milestone Sep 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/visual a/Xaml </> API-change Heads-up to reviewers that this PR may contain an API change ControlGallery p/Android p/iOS 🍎
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants