Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Android] Fix Bottom Tab IsVisible with Shell #11885

Merged
merged 1 commit into from
Aug 24, 2020
Merged

[Android] Fix Bottom Tab IsVisible with Shell #11885

merged 1 commit into from
Aug 24, 2020

Conversation

PureWeen
Copy link
Contributor

Description of Change

Androids ShellItemRenderer is using the wrong data structures for pulling in Visible Items

Issues Resolved

Platforms Affected

  • Android

Testing Procedure

  • ui tests included

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@PureWeen PureWeen added a/shell 🐚 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. labels Aug 22, 2020
@PureWeen PureWeen added this to the 4.8.0 milestone Aug 22, 2020
@samhouts samhouts added this to In Review in vCurrent (4.8.0) Aug 22, 2020
@PureWeen PureWeen requested a review from samhouts August 22, 2020 17:14
@PureWeen
Copy link
Contributor Author

API 19 Failures unrelated

@rmarinho rmarinho merged commit cca1ca6 into 4.8.0 Aug 24, 2020
vCurrent (4.8.0) automation moved this from In Review to Done Aug 24, 2020
@rmarinho rmarinho deleted the fix_11869 branch August 24, 2020 23:19
@samhouts samhouts added this to Done in Sprint 175 Aug 25, 2020
@samhouts samhouts added the approved Has two approvals, no pending reviews, and no changes requested label Aug 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/shell 🐚 approved Has two approvals, no pending reviews, and no changes requested blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. p/Android t/bug 🐛
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants