Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[iOS] Fix position of placeholder (#11889) #11891

Merged
merged 1 commit into from
Aug 25, 2020
Merged

[iOS] Fix position of placeholder (#11889) #11891

merged 1 commit into from
Aug 25, 2020

Conversation

acuntex
Copy link
Contributor

@acuntex acuntex commented Aug 23, 2020

Description of Change

Fixed the position of the placeholder of an Editor control on iOS.

Issues Resolved

API Changes

None

Platforms Affected

  • iOS

Behavioral/Visual Changes

The position of the placeholder of an Editor control on iOS should be correct now.

Before/After Screenshots

XamarinBug_EditorPlaceholder
XamarinBug_EditorPlaceholder_fixed

Testing Procedure

Check CoreGalleryPages/EditorCoreGalleryPage.cs

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@acuntex acuntex changed the title fix position of placeholder (#11889) [iOS] Fix position of placeholder (#11889) Aug 23, 2020
@acuntex
Copy link
Contributor Author

acuntex commented Aug 23, 2020

Sorry about the invalid PR first.

Not sure about any side effects of setting TranslatesAutoresizingMaskIntoConstraints to false, but this should fix it.

@samhouts samhouts merged commit fbadf13 into xamarin:4.8.0 Aug 25, 2020
vCurrent (4.8.0) automation moved this from In Review to Done Aug 25, 2020
@samhouts samhouts added this to Done in Sprint 175 Aug 26, 2020
@samhouts samhouts added this to the 4.8.0 milestone Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants