This repository has been archived by the owner on May 1, 2024. It is now read-only.
[UWP] Changes in CollectionViewSource dispose logic #11919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samhouts
added
retarget-branch-required
jsuarezruiz
force-pushed
the
fix-11908
branch
from
3bbbe0d
to
3cdae39
Compare
hartez
suggested changes
Sep 9, 2020
| CollectionViewSource.Source = null; | ||
| } | ||
|
|
||
| CollectionViewSource.Source = null; |
There was a problem hiding this comment.
Won't this throw an exception is CollectionViewSource is null?
There was a problem hiding this comment.
Yes, but there is a null check in the line 114.
hartez
approved these changes
Sep 11, 2020
rmarinho
approved these changes
Sep 11, 2020
samhouts
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Changes in CollectionViewSource dispose logic on UWP.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Launch Core Gallery and navigate to the CollectionView galleries. Use the profiler to debug and verify that the CollectionViewSource is disposed.
PR Checklist