This repository has been archived by the owner on May 1, 2024. It is now read-only.
[iOS] TextDecoration Strikethrough not working on iOS together with LineHeight #11928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samhouts
added
retarget-branch-required
jsuarezruiz
force-pushed
the
fix-11829
branch
from
2363474
to
2696e39
Compare
hartez
suggested changes
Sep 9, 2020
|
|
||
| namespace Xamarin.Forms.Controls.Issues | ||
| { | ||
| #if UITEST |
There was a problem hiding this comment.
This should be automated with a platform test on iOS - we can verify that the Control's AttributedText has the strikethrough attribute after the Label has LineHeight and TextDecoration set.
samhouts
added
retarget-branch-required
PureWeen
added
the
DO-NOT-MERGE-!!! 🛑
jsuarezruiz
removed
the
DO-NOT-MERGE-!!! 🛑
jfversluis
force-pushed
the
fix-11829
branch
from
bdf2670
to
bee9041
Compare
jfversluis
approved these changes
Nov 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix issue on iOS Label using TextDecoration Strikethrough together with LineHeight.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Testing Procedure
Launch Core Gallery and navigate to the issue 11928. If text is underline, the test has passed.
PR Checklist