Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Android] Snap Points not working in CollectionView with GridItemsLayout #11941

Merged
merged 9 commits into from
Oct 29, 2020

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Aug 27, 2020

Description of Change

Fix Snap Points not working in CollectionView with GridItemsLayout on Android.

Issues Resolved

API Changes

None

Platforms Affected

  • Android

Behavioral/Visual Changes

None

Before/After Screenshots

Before

Not working

After

fix11938

Testing Procedure

Launch Core Gallery and navigate to the issue 11938. If SnapPointsType is working, the test has passed.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just think we should leave a comment.

@samhouts samhouts added the retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. label Aug 31, 2020
@samhouts samhouts changed the base branch from 4.8.0 to 5.0.0 August 31, 2020 23:12
@samhouts samhouts added retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. and removed retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. labels Aug 31, 2020
@samhouts samhouts removed this from In Review in vCurrent (4.8.0) Sep 1, 2020
@samhouts samhouts added this to In Review in vNext+1 (5.0.0) Sep 1, 2020
@jsuarezruiz jsuarezruiz removed the retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. label Sep 17, 2020
@rmarinho rmarinho merged commit dc3d044 into 5.0.0 Oct 29, 2020
vNext+1 (5.0.0) automation moved this from In Review to Done Oct 29, 2020
@rmarinho rmarinho deleted the fix-11938 branch October 29, 2020 20:33
@samhouts samhouts added this to the 5.0.0 milestone Nov 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[Bug] Snap Points not working in CollectionView with GridItemsLayout
4 participants