Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Core,iOS,Droid,UWP,Tizen] Remove MediaElement #12007

Merged
merged 9 commits into from
Sep 10, 2020
Merged

[Core,iOS,Droid,UWP,Tizen] Remove MediaElement #12007

merged 9 commits into from
Sep 10, 2020

Conversation

rmarinho
Copy link
Member

@rmarinho rmarinho commented Sep 2, 2020 •
edited by samhouts
Loading

Description of Change

Remove MediaElement as it moves to XCT , pr soon

Issues Resolved

API Changes

Removed:

  • class MediaElement
  • class MediaElementRenderer

Platforms Affected

  • Core/XAML (all platforms)
  • iOS
  • Android
  • UWP
  • Tizen

Behavioral/Visual Changes

Would need XCT to run Media

Before/After Screenshots

Not applicable

Testing Procedure

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@samhouts
Copy link
Member

samhouts commented Sep 2, 2020

I think MediaSource needs to go, too.

@samhouts samhouts added this to In Review in vNext+1 (5.0.0) Sep 2, 2020
@rookiejava
Copy link
Collaborator

I think below files need to go, too. (for Tizen)

  • Xamarin.Forms.Platform.Tizen/Native/EmbeddingControls.cs
  • Xamarin.Forms.Platform.Tizen/Native/LayoutCanvas.cs
  • Xamarin.Forms.Platform.Tizen/Resource/img_button_pause.png
  • Xamarin.Forms.Platform.Tizen/Resource/img_button_play.png

@rookiejava rookiejava mentioned this pull request Sep 7, 2020
Closed
@samhouts samhouts added the approved Has two approvals, no pending reviews, and no changes requested label Sep 8, 2020
jsuarezruiz
jsuarezruiz suggested changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We almost have it!. But there are some pending lines to remove:

@rmarinho rmarinho merged commit 6b816f7 into 5.0.0 Sep 10, 2020
vNext+1 (5.0.0) automation moved this from In Review to Done Sep 10, 2020
@rmarinho rmarinho deleted the remove-mediaelement branch September 10, 2020 09:22
@samhouts samhouts added this to Done in Sprint 176 Sep 13, 2020
@samhouts samhouts added this to the 5.0.0 milestone Sep 19, 2020
@samhouts samhouts added a/mediaelement breaking Changes behavior or appearance API-change Heads-up to reviewers that this PR may contain an API change deprecation Public API has been deprecated m/high impact ⬛ proposal-open t/enhancement ➕ roadmap labels Sep 22, 2020
@rookiejava rookiejava mentioned this pull request Oct 22, 2020
Merged
5 tasks
@rookiejava rookiejava mentioned this pull request Nov 5, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StephaneDelcroix StephaneDelcroix StephaneDelcroix approved these changes

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

Assignees

@StephaneDelcroix StephaneDelcroix

@jsuarezruiz jsuarezruiz

Labels
a/mediaelement API-change Heads-up to reviewers that this PR may contain an API change approved Has two approvals, no pending reviews, and no changes requested breaking Changes behavior or appearance ControlGallery deprecation Public API has been deprecated m/high impact ⬛ p/Android p/iOS 🍎 p/Tizen p/UWP p/WPF proposal-open roadmap t/enhancement ➕
Projects
No open projects
Sprint 176
  
Done
vNext+1 (5.0.0)
Done
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

[Spec] Major Breaking Changes Proposed for Xamarin.Forms 5.0
5 participants
@rmarinho @samhouts @rookiejava @StephaneDelcroix @jsuarezruiz