This repository has been archived by the owner on May 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤎🤯🤎
rmarinho
reviewed
Sep 10, 2020
pictos
reviewed
Sep 12, 2020
Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com>
pictos
reviewed
Sep 12, 2020
Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com>
samhouts
approved these changes
Sep 18, 2020
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Provide a deferral token during navigating that users can use to invoke async operations
GotoAsync
and all of theINavigation
methods will not resolve until the user has completed all deferralsINavigation
methods to route throughGoToAsync
so that all behavior is symmetricalIssues Resolved
API Changes
Platforms Affected
Testing Procedure
Example usage
Given the following override of OnNavigating if the user tries to do any navigation they will be given a display sheet confirming if the want to navigate. If they click "no" then navigation will be cancelled
If the user calls
GoToAsync
the GoToAsync call will only resolve after the deferral token has been completedDEMO
PR Checklist