Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Tizen] Enhances the shell renderer #12119

Merged
merged 9 commits into from
Sep 17, 2020

Conversation

myroot
Copy link
Contributor

@myroot myroot commented Sep 15, 2020

Description of Change

In this PR, the existing shell renderer has been improved as follows.

  • Refactoring code
    • Removes the Tizen.Material shell renderer (Looks little bit different from normal but Tizen.NET.MaterialComponents not satisfy implementation requirement)
  • Fixes many bugs
    • TitleView was not shown
    • Title was not shown with defaut color
    • TabBarBackgroundColor was not used
  • Implements new features
Property Description
Shell.FlyoutIcon b49d4780-e6ef-11ea-854a-958ce3db7d2f
Shell.FlyoutHeaderBehavior df879b80-e6ef-11ea-8eab-4df673941957
Shell.ItemTemplate / Shell.ItemTemplate 1198fd80-e6f0-11ea-994f-b0376893b0ef
Shell.FlyoutBehavior - Support FlyoutBehavior.Disabled, FlyoutBehavior.Flyout
SearchHandler 52911200-e6f0-11ea-927c-bde084eeb597
Shell.TabBarIsVisible - Support Top TabBar visibility
  • Support multiple screen size scaling
    d2d7f880-ed2a-11ea-956a-1d7459f2c5e7

Issues Resolved

  • fixes #

API Changes

  • Added (Support on tizen)
    • ImageSource Shell.FlyoutIcon
    • FlyoutHeaderBehavior Shell.FlyoutHeaderBehavior
    • DataTemplate Shell.ItemTemplate
    • DataTemplate Shell.MenuItemTemplate
    • FlyoutBehavior Shell.FlyoutBehavior
    • bool Shell.TabBarIsVisible
    • class SearchHandler

Platforms Affected

  • Tizen

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

Copy link
Collaborator

@rookiejava rookiejava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is improving many parts of the shell related implementation for various Tizen devices. To verify this, we internally performed a testing for about 2~3 weeks and confirmed now.

@samhouts samhouts added this to In Review in vNext+1 (5.0.0) Sep 16, 2020
@rmarinho rmarinho merged commit 304023d into xamarin:5.0.0 Sep 17, 2020
vNext+1 (5.0.0) automation moved this from In Review to Done Sep 17, 2020
@samhouts samhouts added this to Done in Sprint 176 Sep 18, 2020
@samhouts samhouts added this to the 5.0.0 milestone Sep 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants