Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Fix flyout render quirks #12129

Merged
merged 10 commits into from
Sep 25, 2020
Merged

Fix flyout render quirks #12129

merged 10 commits into from
Sep 25, 2020

Conversation

pictos
Copy link
Contributor

@pictos pictos commented Sep 15, 2020 •
edited by PureWeen
Loading

Description of Change

  • Fix Flyouts to correctly interpret Flyout.IsVisible at all levels
  • Fix the flyout to check MenuItems for IsVisible
  • Fix groupings so that they skip over implicit routes correctly when creating groups
  • Fix UWP flyout templates to scale correctly to the container
  • Fix UWP styling to set the background to transparent by default
  • Fix flyout rendering on all platforms so the flyout list doesn't re-render every single time you switch pages
  • Fix UWP to propagate selection changes to states correctly

Platforms Affected

  • Core/XAML (all platforms)
  • UWP
  • iOS
  • Android

Testing Procedure

  • verify UWP works as expected and flyout items are generating correctly

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

pictos
pictos commented Sep 15, 2020
View reviewed changes
Xamarin.Forms.Core/Shell/Shell.cs

// If we have only a single child we will also show the items menu items
if ((shellSection as IShellSectionController).GetItems().Count == 1 && shellSection == shellItem.CurrentItem)
if (shellContents.Count == 1 && shellSection == shellItem.CurrentItem && shellSection.CurrentItem.MenuItems.Count > 0)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we need this shellSection.CurrentItem.MenuItems.Count > 0

@PureWeen PureWeen removed the request for review from StephaneDelcroix September 15, 2020 23:23
@PureWeen PureWeen added the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Sep 16, 2020
@pictos
Copy link
Contributor Author

pictos commented Sep 16, 2020

All green here! ✅

@PureWeen PureWeen added a/shell 🐚 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. p/UWP and removed DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. labels Sep 16, 2020
@PureWeen
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@samhouts samhouts added the Core label Sep 17, 2020
@samhouts samhouts added this to In Progress in vNext+1 (5.0.0) Sep 17, 2020
@rmarinho rmarinho merged commit 65e22f0 into xamarin:5.0.0 Sep 25, 2020
vNext+1 (5.0.0) automation moved this from In Progress to Done Sep 25, 2020
@samhouts samhouts added this to the 5.0.0 milestone Oct 5, 2020
@pictos pictos deleted the fix_flyout_render_quirks branch December 9, 2022 00:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

@PureWeen PureWeen PureWeen approved these changes

Assignees

@rmarinho rmarinho

@PureWeen PureWeen

Labels
a/shell 🐚 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. Core p/Android p/iOS 🍎 p/UWP
Projects
No open projects
vNext+1 (5.0.0)
Done
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pictos @PureWeen @rmarinho @samhouts