Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[All] Basic Right-To-Left Support #1222

Merged
merged 15 commits into from
Nov 9, 2017
Merged

[All] Basic Right-To-Left Support #1222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
5152708
Restart RTL work
Aug 3, 2016
02b6420
Remove IsInherited flag as it never got used
Oct 27, 2017
85b6ed4
[Core] Unit tests
samhouts Nov 1, 2017
dd88925
[Core] FlowDirection
samhouts Nov 1, 2017
0f8a54a
Add FlowDirectionGallery
samhouts Nov 1, 2017
2e4178a
Android gallery supports RTL
samhouts Nov 1, 2017
4aeebbe
iOS gallery supports RTL
samhouts Nov 1, 2017
7506aee
UWP gallery supports RTL
samhouts Nov 1, 2017
302ad3c
[Android] Implement FlowDirection
samhouts Nov 1, 2017
4f7c0fa
[iOS] Implement FlowDirection
samhouts Nov 1, 2017
6edde8c
[macOS] Implement FlowDirection
samhouts Nov 1, 2017
63fb40d
[UWP] Implement FlowDirection
samhouts Nov 1, 2017
63fba59
Update docs
samhouts Nov 1, 2017
d618900
[Core] Simplify EffectiveFlowDirection enum & expose helper extensions
samhouts Nov 2, 2017
5ec00b4
Update docs
samhouts Nov 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Xamarin.Forms.ControlGallery.Android/Properties/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<uses-permission android:name="android.permission.READ_LOGS" />
<uses-permission android:name="android.permission.BIND_NOTIFICATION_LISTENER_SERVICE" />
<uses-feature android:glEsVersion="0x00020000" android:required="true" />
<application android:label="AndroidControlGallery">
<application android:label="AndroidControlGallery" android:supportsRtl="true">
<meta-data android:name="com.google.android.gms.version" android:value="@integer/google_play_services_version" />
</application>
</manifest>
2 changes: 1 addition & 1 deletion Xamarin.Forms.ControlGallery.WP8/App.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ void InitializeLanguage()
//
// If a compiler error is hit then ResourceFlowDirection is missing from
// the resource file.
FlowDirection flow = (FlowDirection)Enum.Parse(typeof(FlowDirection), AppResources.ResourceFlowDirection);
System.Windows.FlowDirection flow = (System.Windows.FlowDirection)Enum.Parse(typeof(System.Windows.FlowDirection), AppResources.ResourceFlowDirection);
RootFrame.FlowDirection = flow;
}
catch
Expand Down
2 changes: 2 additions & 0 deletions Xamarin.Forms.ControlGallery.WindowsUniversal/Package.appxmanifest
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
</Dependencies>
<Resources>
<Resource Language="x-generate" />
<Resource Language="en" />
<Resource Language="ar" />
</Resources>
<Applications>
<Application Id="App" Executable="$targetnametoken$.exe" EntryPoint="Xamarin.Forms.ControlGallery.WindowsUniversal.App">
Expand Down
7 changes: 7 additions & 0 deletions Xamarin.Forms.ControlGallery.iOS/Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,13 @@
<string>{320, 480}</string>
</dict>
</array>
<key>CFBundleDevelopmentRegion</key>
<string>en</string>
<key>CFBundleLocalizations</key>
<array>
<string>en</string>
<string>ar</string>
</array>
<key>NSAppTransportSecurity</key>
<dict>
<key>NSAllowsArbitraryLoads </key>
Expand Down
5 changes: 4 additions & 1 deletion Xamarin.Forms.ControlGallery.iOS/Xamarin.Forms.ControlGallery.iOS.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
<MtouchUseLlvm>False</MtouchUseLlvm>
<MtouchUseThumb>False</MtouchUseThumb>
<MtouchOptimizePNGs>True</MtouchOptimizePNGs>
<MtouchI18n />
<MtouchI18n>mideast</MtouchI18n>
<BuildIpa>True</BuildIpa>
<IpaMetadata />
<IpaPackageName />
Expand Down Expand Up @@ -132,6 +132,9 @@
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'AppStore|iPhoneSimulator'">
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
</PropertyGroup>
<PropertyGroup Condition=" '$(RunConfiguration)' == 'Default' ">
<AppExtensionDebugBundleId />
</PropertyGroup>
<ItemGroup>
<Compile Include="BrokenImageSourceHandler.cs" />
<Compile Include="BrokenNativeControl.cs" />
Expand Down
Loading