Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Leave IMasterDetailPageController intact #12317

Merged
merged 3 commits into from
Oct 9, 2020
Merged

Leave IMasterDetailPageController intact #12317

merged 3 commits into from
Oct 9, 2020

Conversation

PureWeen
Copy link
Contributor

Description of Change

Separate out IMasterDetailPageController from IFlyoutPageController so it's not an ABI break

Issues Resolved

Platforms Affected

  • Core/XAML (all platforms)
  • iOS
  • Android
  • UWP

Testing Procedure

  • I'll reach out to user to verify

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@PureWeen PureWeen added the blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. label Oct 1, 2020
@samhouts samhouts added this to In Review in vNext+1 (5.0.0) Oct 1, 2020
@PureWeen PureWeen requested a review from samhouts October 2, 2020 15:35
@PureWeen
Copy link
Contributor Author

PureWeen commented Oct 5, 2020

UI Tests are here

https://dev.azure.com/xamarin/public/_releaseProgress?_a=release-pipeline-progress&releaseId=2370

@samhouts samhouts merged commit 31e7552 into 5.0.0 Oct 9, 2020
vNext+1 (5.0.0) automation moved this from In Review to Done Oct 9, 2020
@samhouts samhouts deleted the restore_IMDPC branch October 9, 2020 20:34
@samhouts samhouts added this to the 5.0.0 milestone Oct 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samhouts samhouts samhouts approved these changes

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix is a code owner

Assignees
No one assigned
Labels
5.0.0 Regression on 5.0.0 a/masterdetailpage a/mdp blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. Core hacktoberfest 🍻 hacktoberfest-accepted i/regression t/bug 🐛
Projects
No open projects
vNext+1 (5.0.0)
Done
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

[Bug] Xamarin.Forms 5 MasterDetailPage renaming broke plugins
2 participants
@PureWeen @samhouts