Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Added implementation for failure handling method for WkWe… #12327

Merged

Conversation

aaRopi
Copy link
Contributor

@aaRopi aaRopi commented Oct 1, 2020

…bview.

Description of Change

Added implementation for failure handling method for WkWebViewRenderer.

  • WkNavigationDelegate has 2 methods for failure handling as can be seen here.

  • Only one of them was implemented as can be seen from the source of WkWebViewRenderer here.

Issues Resolved

API Changes

None

Platforms Affected

  • iOS

Behavioral/Visual Changes

On iOS, when loading a url in the WebView, if there is no internet connection available, the WebView should fire a Navigated event with WebNavigationResult.Failure.

Before/After Screenshots

Not applicable

Testing Procedure

Tested with iOS 14 simulator.

  • Hook into WebView.Navigated event.
  • Run app on iOS (simulator or device) without internet connection.
  • Handler for WebView.Navigated should be called now.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@rmarinho rmarinho merged commit ab2325c into xamarin:4.8.0 Nov 5, 2020
vCurrent (4.8.0) automation moved this from In Review to Done Nov 5, 2020
@aaRopi aaRopi deleted the fix_ios_wkwebviewrenderer_handle_fail branch November 5, 2020 12:26
@samhouts samhouts modified the milestone: 4.8.0 Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants