Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

set the RowHeight to prevent listview from being greedy #12346

Merged
merged 2 commits into from
Sep 22, 2021

Conversation

t-johnson
Copy link
Contributor

@t-johnson t-johnson commented Oct 3, 2020

Description of Change

Set the RowHeight to prevent the ListView from being greedy about space. This was causing the buttons in the StackLayout to shrink when the window was wide,

Issues Resolved

API Changes

None

Platforms Affected

  • Core/XAML (all platforms)

Behavioral/Visual Changes

None

Before/After Screenshots

Testing Procedure

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@samhouts samhouts added good first issue hacktoberfest 🍻 t/housekeeping ♻︎ Internal only changes, won't be included in release notes hacktoberfest-accepted labels Oct 4, 2020
@samhouts samhouts added this to In Review in vNext+1 (5.0.0) Nov 2, 2020
@PureWeen PureWeen added this to In progress in v5.0.1 via automation Nov 5, 2020
@PureWeen PureWeen removed this from In Review in vNext+1 (5.0.0) Nov 5, 2020
@samhouts samhouts added this to In Review in vNext+1 (5.0.0) Nov 5, 2020
@samhouts samhouts removed this from In progress in v5.0.1 Nov 5, 2020
@PureWeen PureWeen added this to In progress in v5.0.1 via automation Nov 5, 2020
@PureWeen PureWeen removed this from In Review in vNext+1 (5.0.0) Nov 5, 2020
v5.0.1 automation moved this from In progress to Reviewer approved Sep 22, 2021
@jsuarezruiz jsuarezruiz merged commit 8426694 into xamarin:5.0.0 Sep 22, 2021
v5.0.1 automation moved this from Reviewer approved to Done Sep 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Development

Successfully merging this pull request may close these issues.

UI Test B40173 renders incorrectly on UWP
4 participants