This repository has been archived by the owner on May 1, 2024. It is now read-only.
[iOS] Fix issue disposing the EmptyView #12377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samhouts
added
i/high
|
When will this be merged? |
|
Can you add a UITest @jsuarezruiz ? |
|
Added UITest. |
|
What timing. I came back yesterday to see what progress was on this issue because I've hit a bunch of other XF5 issues I've been slogging through. Good to see its fixed though! Thanks @jsuarezruiz |
rmarinho
approved these changes
Nov 13, 2020
rmarinho
added
the
blocker
hartez
approved these changes
Nov 16, 2020
|
Today after updating to the newest preview of XF my EmptyViews were just not showing anymore and a tap in the area where the EmptyView is supposed to be just crashed the app (SIGSEGV). Only tested on iOS. |
|
Sorry @vniehues but it didn't make into pre4, but is merged for the next pre-- Can you try this nugets and see if it fixes your issue.. |
This was referenced Dec 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Hiding the native
EmptyViewwe removed it from the superview (UICollectionView). This PR include changes to dispose the view and set it to null. This way, after show again the EmptyView, creates a new one and does not attempt to access a disposed view.Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Testing Procedure
Launch Core Gallery and navigate to the issue 12374. Tap each item to remove them and view the EmptyView. Then, tap the AddItems button. Without crash, the test has passed.
PR Checklist