Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Calculate Nav Source and fix popping params #12514

Merged
merged 8 commits into from
Oct 23, 2020
Merged

Calculate Nav Source and fix popping params #12514

merged 8 commits into from
Oct 23, 2020

Conversation

PureWeen
Copy link
Contributor

Description of Change

  • Fix ShellNavigationSource so it's correctly calculated based on diff of source/dest
  • When popping using ".." don't clear parameters on previous page

Platforms Affected

  • Core/XAML (all platforms)

Testing Procedure

  • unit tests pass
  • UI tests pass

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@PureWeen PureWeen removed the request for review from StephaneDelcroix October 17, 2020 02:07
pictos
pictos approved these changes Oct 18, 2020
View reviewed changes
Copy link
Contributor

@pictos pictos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All works here on my side. I have just a small suggestion but that doesn't invalidate this PR.

Xamarin.Forms.Core/Shell/Shell.cs Outdated Show resolved Hide resolved
@PureWeen PureWeen added the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Oct 19, 2020
@PureWeen PureWeen removed the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Oct 19, 2020
@PureWeen PureWeen merged commit 3b5b760 into 5.0.0 Oct 23, 2020
@PureWeen PureWeen deleted the fix_shell_nav_quirks branch October 23, 2020 15:55
@PureWeen PureWeen mentioned this pull request Oct 28, 2020
Open
@samhouts samhouts added this to Done in vNext+1 (5.0.0) Nov 2, 2020
@samhouts samhouts added this to the 5.0.0 milestone Nov 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pictos pictos pictos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
vNext+1 (5.0.0)
Done
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PureWeen @pictos @samhouts