Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Fixes 7913 Add UWP shell flyout scroll mode support #12547

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

bmacombe
Copy link
Contributor

Description of Change

Adds UWP support for #4765

Issues Resolved

API Changes

None

Platforms Affected

  • UWP

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

Launch UWP Gallery, go to test page 4765. Add enough shell items to make the nav flyout need to scroll. Change the scroll mode and verify behavior.

When scrolling is disabled, the scroll bar will also be hidden.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

Copy link
Contributor

@pictos pictos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on my and works fine.

@samhouts samhouts added this to In Review in vNext+1 (5.0.0) Nov 2, 2020
@PureWeen PureWeen added this to the 5.0.0 milestone Nov 5, 2020
@PureWeen PureWeen added the blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. label Nov 5, 2020
@PureWeen
Copy link
Contributor

PureWeen commented Nov 5, 2020

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@rmarinho rmarinho merged commit ca423eb into xamarin:5.0.0 Nov 6, 2020
vNext+1 (5.0.0) automation moved this from In Review to Done Nov 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/shell 🐚 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. p/UWP t/bug 🐛
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[Shell, UWP] Cannot prevent flyout menu list from scrolling.
6 participants