This repository has been archived by the owner on May 1, 2024. It is now read-only.
Correction of CollectionView to work properly with selected item color #12651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r when using VisualState on Android and iOS
2 tasks
rmarinho
suggested changes
Oct 29, 2020
rmarinho
approved these changes
Oct 30, 2020
rmarinho
added
blocker
jsuarezruiz
approved these changes
Oct 30, 2020
| } | ||
| } | ||
|
|
||
| bool IsUsingVSMForSelectionColor(View view) |
There was a problem hiding this comment.
This is is repeated on iOS and Android, could we maybe move it to an extension method?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This was orginally #11604 from @ronymesquita. We had to re-create the PR due to some CI and merging issues.
Description of Change
The key idea is to resolve the problem of CollectionView with selected item color on Android and iOS.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
The platform will check if exists a
Visual StatewithSelectedand not use the default color. In this manner, the background color of theVisual Statewill not be overridden by Android. On iOS, the background color is cleaned when theSelectedstate exists.The default behavior still works.
Before/After Screenshots
After (Android)
After (iOS)
Testing Procedure
The test was manual.
PR Checklist