Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[iOS] Fixed IndicatorView rendering issue on iOS 14 #12654

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Oct 29, 2020

Description of Change

Fixed IndicatorView rendering issue on iOS 14.

In iOS 14, We have a new styling option for a UIPageControl called BackgroundStyle. This is an enum with three values:

  • Automatic: The default background style that adapts based on the current interaction state.
  • Prominent: The background style that shows a full background regardless of the interaction
  • Minimal :The background style that shows a minimal background regardless of the interaction

Apple also has provided a new way to manage the interaction for the UIPageControl in iOS14 called InteractionState. AllowsContinuousInteraction allow us in a. simple way to manage if we want continuous interaction or not.

To maintain the IndicatorView behavior, this PR introduce changes using the previous properties only in iOS 14.

Issues Resolved

API Changes

None

Platforms Affected

  • iOS

Behavioral/Visual Changes

None

Before/After Screenshots

fix12028

Testing Procedure

Launch Core Gallery on iOS 14 and navigate to the IndicatorView Gallery. Verify that the IndicatorView renders as expected.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@rmarinho rmarinho merged commit 5a770f9 into 5.0.0 Oct 29, 2020
@rmarinho rmarinho deleted the fix-12028 branch October 29, 2020 15:56
@samhouts samhouts added a/carouselview iOS 14 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. labels Nov 2, 2020
@samhouts samhouts modified the milestone: 5.0.0 Nov 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/carouselview a/indicatorview blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. iOS 14 p/iOS 🍎 t/bug 🐛
Projects
None yet
3 participants