This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Android/iOS] Fixed issue resolving a Renderer from a TemplatedView #12658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
commented
Oct 29, 2020
| renderer = Registrar.Registered.GetHandlerForObject<IVisualElementRenderer>(element, context) | ||
| ?? new DefaultRenderer(context); | ||
| } | ||
| IVisualElementRenderer renderer = Registrar.Registered.GetHandlerForObject<IVisualElementRenderer>(element, context) |
There was a problem hiding this comment.
This changed when added the Templated RadioButton. In the case of TemplatedView, DefaultRenderer was always used. I understand that the change was performance related. However, if the TemplatedView has an associated renderer registered it would stop working. @hartez Check the PR when you can ;)
samhouts
added
ControlGallery
a/customrenderer
blocker
|
Can we add a UITEst or Platform test for this ? |
|
Sure, added UITest. |
hartez
approved these changes
Dec 18, 2020
PureWeen
approved these changes
Dec 18, 2020
|
failing tests not related |
|
Is this fix moved in nuget.org? |
|
Yes pre6. you can try it . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixed issue resolving a Renderer from a TemplatedView.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Launch Core Gallery and navigate to the issue 12484. If the renderer
OnElementChangedmethod is invoked, the test has passed.PR Checklist