Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Remove WRITE_EXTERNAL_STORAGE from maps #12698

Merged
merged 1 commit into from
Nov 2, 2020
Merged

Remove WRITE_EXTERNAL_STORAGE from maps #12698

merged 1 commit into from
Nov 2, 2020

Conversation

PureWeen
Copy link
Contributor

Description of Change

Write_External_storage is no longer needed if you are targeting 23+

https://developers.google.com/maps/documentation/android-sdk/config#external-storage-permission

You're required to target API 29 to release to the play store. If for some reason a user needs to target lower than 23 they can just add the permission in themselves

Issues Resolved

Platforms Affected

  • Android

Testing Procedure

  • Ensure that the release nuget package loads maps correctly without having to set the WRITE_EXTERNAL_STORAGE permission

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@rmarinho rmarinho merged commit e2197ba into 5.0.0 Nov 2, 2020
@rmarinho rmarinho deleted the fiX_12680 branch November 2, 2020 10:55
@samhouts samhouts added this to the 5.0.0 milestone Nov 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Xamarin.Forms.Maps adds permisson WRITE_EXTERNAL_STORAGE to Android project
3 participants