This repository has been archived by the owner on May 1, 2024. It is now read-only.
Dismiss UISearchController when losing focus #12701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazo0
force-pushed
the
sb/ios-search-handler-dismiss
branch
from
63703c8
to
7727aa6
Compare
kazo0
changed the title
|
Any update? |
kazo0
force-pushed
the
sb/ios-search-handler-dismiss
branch
2 times, most recently
from
e6cfc4e
to
aba57b0
Compare
|
Is there a plan to get this merged soon? Seems there are a few fixed issues in pull requests that would fix bugs in my app but they are not being merged. Just wondering whether I need to write a workaround or wait. |
|
Any update? |
|
@kazo0 Could you rebase your branch to fix the conflicts?. Thanks! |
kazo0
force-pushed
the
sb/ios-search-handler-dismiss
branch
from
7c469d6
to
093f634
Compare
|
@jsuarezruiz done! |
jsuarezruiz
approved these changes
Sep 24, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I know, after more than a year, you are still anxiously looking every day at this PR @kazo0, but today is the day it is finally merged. You can now go forth and call yourself a Xamarin.Forms contributor! 🦸 Thank you so much for your time and effort on this and sorry we didn't get to it sooner! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Dismiss UISearchController when losing focus
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
When a query is confirmed in SearchHandler, the search handler will lose focus and will no longer display a dimmed view on top of the remaining page
Before/After Screenshots
Not applicable
Testing Procedure
PR Checklist