This repository has been archived by the owner on May 1, 2024. It is now read-only.
Remove unnecessary UpdateConstraints calls when rotating #12728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartez
added
a/carouselview
blocker
rmarinho
suggested changes
Nov 5, 2020
|
failing tests ios12/ios11 -- not sure why on CI reports 51 and here just 18 and 1 :/ |
rmarinho
approved these changes
Nov 11, 2020
jsuarezruiz
approved these changes
Nov 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Removes unnecessary constraints update calls during InvalidateLayout which were causing auto-layout errors for CarouselView (and making HTML Labels occasionally disappear).
Also removes some unecessary overrides from CarouselView Layout/Controller (deferring to ItemsView Layout/Controller).
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Automated test
PR Checklist