Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[iOS] Remove hardcoded value on CarouselView loop calculations #12787

Merged
merged 5 commits into from
Nov 12, 2020
Merged

[iOS] Remove hardcoded value on CarouselView loop calculations #12787

merged 5 commits into from
Nov 12, 2020

Conversation

rmarinho
Copy link
Member

@rmarinho rmarinho commented Nov 9, 2020 •
edited
Loading

Description of Change

Don't use hardcoded number to fix calculations to recenter the CarouselView and fake the loop feature when the collection just has a couple of items.

Issues Resolved

API Changes

None

Platforms Affected

  • iOS

Behavioral/Visual Changes

Should not crash.

Before/After Screenshots

Not applicable

Testing Procedure

Added uitkst for issue 12574, make sure you can scroll the items.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@rmarinho rmarinho added the blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. label Nov 9, 2020
@rmarinho rmarinho added this to To do in vNext+1 (5.0.0) via automation Nov 9, 2020
@rmarinho rmarinho mentioned this pull request Nov 10, 2020
Closed
@rmarinho rmarinho linked an issue Nov 10, 2020 that may be closed by this pull request
[Bug] XF5+ CarouselView crashes If last Item is removed #12673
Closed
@rmarinho rmarinho moved this from To do to In Review in vNext+1 (5.0.0) Nov 10, 2020
@jsuarezruiz
Copy link
Contributor

Failing UITests seem unrelated (not CarouselView tests).

@rmarinho
Copy link
Member Author

failing tests are not related.

@rmarinho rmarinho added the i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often label Nov 11, 2020
jsuarezruiz
jsuarezruiz suggested changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is working fine, and the changes have sense but, can we modify the sample to remove/add item/s. Just to be sure the loop calculations are correct changing the items count.

@rmarinho rmarinho merged commit 06ccda8 into 5.0.0 Nov 12, 2020
vNext+1 (5.0.0) automation moved this from In Review to Done Nov 12, 2020
@rmarinho rmarinho deleted the fix-12574 branch November 12, 2020 17:53
@samhouts samhouts modified the milestone: 5.0.0 Nov 16, 2020
@jsuarezruiz jsuarezruiz mentioned this pull request Nov 18, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hartez hartez hartez approved these changes

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

Assignees
No one assigned
Labels
a/carouselview a/collectionview blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often p/iOS 🍎 t/bug 🐛
Projects
No open projects
vNext+1 (5.0.0)
Done
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

[Bug] XF5+ CarouselView crashes If last Item is removed [Bug] CarouselView Loop=True default freezes iOS app
4 participants
@rmarinho @jsuarezruiz @hartez @samhouts