Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Android] Button disappears when setting CornerRadius #12816

Merged
merged 6 commits into from
Dec 30, 2020
Merged

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Nov 12, 2020

Description of Change

Button disappears when setting CornerRadius. As I have commented in the issue, I cannot reproduce it. For that reason, this PR only includes a test to validate that works as expected.

Issues Resolved

API Changes

None

Platforms Affected

  • Android

Behavioral/Visual Changes

None

Before/After Screenshots

fix12315

Testing Procedure

Launch Core Gallery in an Android 10 device or emulator and navigate to the issue 12315. Change the Slider Value to modify the Button CornerRadius. If the Button is visible, the test has passed.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@samhouts samhouts added the blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. label Dec 10, 2020
@rmarinho rmarinho requested a review from hartez December 29, 2020 23:39
@rmarinho rmarinho added this to the 5.0.0 milestone Dec 29, 2020
@rmarinho rmarinho added this to To do in vNext+1 (5.0.0) via automation Dec 29, 2020
@rmarinho rmarinho moved this from To do to In Review in vNext+1 (5.0.0) Dec 29, 2020
@PureWeen PureWeen added the t/housekeeping ♻︎ Internal only changes, won't be included in release notes label Dec 30, 2020
@PureWeen PureWeen merged commit c27efa3 into 5.0.0 Dec 30, 2020
vNext+1 (5.0.0) automation moved this from In Review to Done Dec 30, 2020
@PureWeen PureWeen deleted the fix-12315 branch December 30, 2020 16:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/brushes a/button blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. p/Android t/bug 🐛 t/housekeeping ♻︎ Internal only changes, won't be included in release notes
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[Bug] Button disappears when setting CornerRadius
4 participants